Fix service.xml creating #1256
Merged
Fix service.xml creating #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx, currently i was also preparing the release updates ;) |
|
ok maybe create a seperate PR for ir, that we can see what is broken is time ;) |
|
I have reverted the travis changes, so that the Pull Request contains only the need. And because the tests are failing with the newest PhpStorm release :) (https://travis-ci.org/Haehnchen/idea-php-symfony2-plugin/jobs/458545150) |
|
@Haehnchen done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PhpStorm 2018.2 is the xml service creation broken. It cannot find the file. That makes me angry everytime when i need a services.xml
So here is the fix. It seems so that the /resources is not more needed anymore. I removed that, and he can find now the files.
I have also updated the Pipeline for PhpStorm 2018.3 release