-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlxG: Add FlxG.onMobile #1904
FlxG: Add FlxG.onMobile #1904
Conversation
Also rename `isMobile` in HTML5FrontEnd to `onMobile`
|
||
private static inline function get_onMobile():Bool | ||
{ | ||
if (onMobile == null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this check? Why not make it @:isVar public static var onMobile(get, never):Bool
and
private static inline function get_onMobile():Bool {
return #if js blah #elseif mobile true #else false #end;
}
Not sure why Travis didn't build. It's been working OK in my project so far. |
Travis fails every project for the same reason, something weird on cpp and neko. |
All the builds were successful but still exited with 1? |
Yeah, if you look closely,
on Haxe 3.2.0 neko and Haxe dev neko/cpp for every recent pull request. This pull is fine since all the demos and coverages passed. |
Thanks! I'm not a huge fan of putting even more stuff into The Travis failures are indeed unrelated, I'm noto sure what's causing them yet. I don't like the formatting of |
Also removed the unnecessary @:isVar.
Also removed the unnecessary @:isVar.
Also I renamed
isMobile
in HTML5FrontEnd toonMobile
since it sounds better.