Add support for synthetic events (CustomEvent) #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthetic events use CustomEvent(), which contains
a customizable `detail` attribute. This commit allows
that attribute to be passed to the Haskell side, allowing
one to, say, use:
```haskell
on (domEvent "myEvent") elm $ ...
```
on the Haskell side, and:
```javascript
var ev = new CustomEvent("myEvent", { detail: ... });
elm.dispatchEvent(ev);
```
on the JavaScript side.
Cf. <https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent>
meteficha
changed the title
|
This seems very useful, anything blocking its review? |
A lack of leisure time? 😄🖇 I wasn't quite sure how this affects marshalling event data. Apparently, it doesn't, event data is still JSON. Merged, thanks! |
|
Wicked, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthetic events use
CustomEvent(), which contains a customizabledetailattribute. This PR allows that attribute to be passed to the Haskell side, allowing one to, say, use:on the Haskell side, and:
on the JavaScript side.
Cf. https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent