Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent and weird preview popup height when key has an icon #811

Closed
Helium314 opened this issue May 26, 2024 · 4 comments
Closed

Inconsistent and weird preview popup height when key has an icon #811

Helium314 opened this issue May 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Helium314
Copy link
Owner

Helium314 commented May 26, 2024

Describe the bug
Height of preview popups is sometimes inconsistent, at least for the ZWNJ key.

To Reproduce
Have Pop-up on key press enabled.
Restart the keyboard (open settings and swipe away in recents).
Switch to Persian an press the ZWNJ key, see normal preview popup.
Press some other key, and then ZWNJ key again, see weirdly high popup.
Maybe also other keys are affected? Edit: yes, keys with icons have this problem

App version
2.0-beta1

Device:

  • Model: S4 Mini
  • OS: Android 9 / LineageOS 16
@Helium314 Helium314 added bug Something isn't working low priority This issue is unlikely to be resolved in the near future due to maintainers' priorities labels May 26, 2024
@Helium314
Copy link
Owner Author

Thanks! I'll have a look.

@Helium314
Copy link
Owner Author

No change after reverting, so probably it's caused by something else.

@Helium314
Copy link
Owner Author

Seems to occur (mostly / always?) when the key has an icon instead of a letter.

@Helium314 Helium314 removed the low priority This issue is unlikely to be resolved in the near future due to maintainers' priorities label Jun 8, 2024
@Helium314 Helium314 changed the title Inconsistent and weird preview popup height for ZWNJ key. Inconsistent and weird preview popup height when key has an icon Jun 8, 2024
@Helium314
Copy link
Owner Author

No change after reverting, so probably it's caused by something else.

Looks like I did something wrong when testing, it's indeed caused by #744

@Helium314 Helium314 self-assigned this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant