Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-swipes can be triggered when the popup keys panel had previously been shown #918

Closed
devycarol opened this issue Jun 27, 2024 · 3 comments · Fixed by #919
Closed

Key-swipes can be triggered when the popup keys panel had previously been shown #918

devycarol opened this issue Jun 27, 2024 · 3 comments · Fixed by #919
Labels
bug Something isn't working

Comments

@devycarol
Copy link
Contributor

Describe the bug
Key-swipes for space and delete can be initiated when hovered during a drag in which the pop-up keys panel had shown. You can browse different pop-up panels in the same drag, so there's a risk of triggering these gestures when doing so.

To Reproduce

  • Enable delete swipe
  • Switch to symbols keyboard (assuming you have gesture typing enabled, otherwise the bug exists in the alpha layout as well)
  • Long-press a key with pop-ups such as the dollar sign
  • Hover over to the delete key
  • It will activate the deletion gesture

Likewise for the space bar, even if it doesn't have a gesture enabled (it'll freeze and prevent further browsing).

Expected behavior
Key-swipes should only start if the gesturing key was the key that was initially pressed down on.

App version
Debug, commit efd7d53

Device:

  • Model: Pixel 5a
  • OS: Android 14—LineageOS 21
@devycarol devycarol added the bug Something isn't working label Jun 27, 2024
@Helium314
Copy link
Owner

What do you mean with hover? Using a mouse or a stylus?

@devycarol
Copy link
Contributor Author

'Hovered' as in dragging your finger to that key from a different point on the screen.

@Helium314
Copy link
Owner

Ok, I wasn't sure because Android also supports actual hover events: https://developer.android.com/reference/android/view/View.OnHoverListener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants