Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport subpackages #116

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Reexport subpackages #116

wants to merge 3 commits into from

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Nov 14, 2024

When using Herb, we usually end up having to also type using HerbGrammar, HerbSearch etc., meaning we don't get any benefit from using Herb in the first place. This change allows you to access anything exported from HerbGrammar, HerbSearch, etc. after only using Herb.

Before, this failed:

using Herb
# needs using HerbGrammar

# or HerbGrammar.@cfgrammar
g = @cfgrammar begin
    a = 1
end

but with this change, it works without the extra using or extra HerbGrammar. before the macro call.

As this just opens up the subpackages' APIs, it is not a
breaking change.
@ReubenJ ReubenJ self-assigned this Nov 14, 2024
@ReubenJ ReubenJ added the enhancement New feature or request label Nov 14, 2024
@ReubenJ ReubenJ marked this pull request as draft November 26, 2024 10:39
@ReubenJ
Copy link
Member Author

ReubenJ commented Nov 26, 2024

Re-exporting triggers a lot of warnings from Aqua since we haven't been testing. Slowly working through each of the subpackages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant