Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Ordered constraint propagation before all holes are filled #10

Open
2 tasks
jaapdejong15 opened this issue Jun 15, 2023 · 0 comments
Open
2 tasks
Labels
enhancement New feature or request

Comments

@jaapdejong15
Copy link
Member

jaapdejong15 commented Jun 15, 2023

Ordered(MatchNode(2, [MatchVar(:a), MatchVar(:b), MatchVar(:c)]), [:a, :b, :c]) is not as efficient as it can be, because it only starts to do anything when there are no holes left, which makes it possible to get things like 3, 2, ?? before the ordered constraint starts to have an effect.

To fix this, we need to:

  • Remove any short-circuiting on softfail in all matching functions
  • Also enforce the order in the propagate function for LocalOrdered in case of a softfail, for all assigned variables.
@jaapdejong15 jaapdejong15 added the enhancement New feature or request label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant