Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review HerbConstraints merge properly #30

Open
THinnerichs opened this issue Apr 4, 2024 · 1 comment
Open

Review HerbConstraints merge properly #30

THinnerichs opened this issue Apr 4, 2024 · 1 comment
Assignees
@THinnerichs @pwochner

Comments

@THinnerichs
Copy link
Member

THinnerichs commented Apr 4, 2024 •
edited
Loading

FixedShapeIterator PR is very big. It was merged for now as tests are very detailed and pass. However, a proper review is mandatory.
@ReubenJ
Copy link
Member

ReubenJ commented Apr 4, 2024 •
edited
Loading

The HerbCore version is outdated meaning that the CI currently fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@THinnerichs THinnerichs

@pwochner pwochner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ReubenJ @THinnerichs @pwochner