Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider extending AbstractTrees interface to *Holes #65

Open
ReubenJ opened this issue Oct 8, 2024 · 0 comments
Open

Consider extending AbstractTrees interface to *Holes #65

ReubenJ opened this issue Oct 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ReubenJ
Copy link
Member

ReubenJ commented Oct 8, 2024

For example, I've found it useful to define

AbstractTrees.children(node::StateHole) = node.children

This is the same way as we've defined it already for RuleNodes in `HerbGrammar.

I'm not sure if it makes sense to define this per concrete type or define it on the abstract type AbstractRuleNode.

@ReubenJ ReubenJ added the enhancement New feature or request label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant