Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken export #12

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Oct 18, 2024

The name that was being exported wasn't actually in the library.

@mhauru
Copy link
Contributor Author

mhauru commented Oct 18, 2024

@pwochner

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.45%. Comparing base (d9de26b) to head (86e2a5a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   50.00%   45.45%   -4.55%     
==========================================
  Files           2        1       -1     
  Lines          12       11       -1     
==========================================
- Hits            6        5       -1     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pwochner pwochner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting. Looks good.

@ReubenJ
Copy link
Member

ReubenJ commented Oct 23, 2024

Yes, thanks! Just added Aqua to the tests so that we don't do this on accident in the future.

@ReubenJ ReubenJ merged commit e8521bd into Herb-AI:master Oct 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants