Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #13

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Add more tests #13

merged 3 commits into from
Oct 23, 2024

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Oct 18, 2024

Something I noticed while writing these tests: getindex for MetricProblem returns a Problem rather than a MetricProblem:

Base.getindex(p::MetricProblem{Vector{IOExample}}, indices) = Problem(p.spec[indices])

Is this intentional?

@mhauru
Copy link
Contributor Author

mhauru commented Oct 18, 2024

@pwochner

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d9de26b) to head (a3e2bc9).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##           master       #13       +/-   ##
============================================
+ Coverage   50.00%   100.00%   +50.00%     
============================================
  Files           2         1        -1     
  Lines          12        14        +2     
============================================
+ Hits            6        14        +8     
+ Misses          6         0        -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@THinnerichs
Copy link
Member

Good catch, this should indeed return a MetricProblem. We currently do not have any metric problem within our benchmarks at this point. Hence, this did not come up earlier.

Copy link
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ReubenJ ReubenJ merged commit 4073698 into Herb-AI:master Oct 23, 2024
5 checks passed
@ReubenJ ReubenJ linked an issue Nov 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage
3 participants