Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value equality #20

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Value equality #20

merged 2 commits into from
Nov 15, 2024

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Nov 14, 2024

Adds equality definitions and hash definitions for structs via the AutoHashEquals.jl package.

@ReubenJ ReubenJ added the enhancement New feature or request label Nov 14, 2024
@ReubenJ ReubenJ self-assigned this Nov 14, 2024
@ReubenJ ReubenJ linked an issue Nov 14, 2024 that may be closed by this pull request
@ReubenJ ReubenJ marked this pull request as draft November 14, 2024 16:13
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9d06378) to head (947278c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           14        14           
=========================================
  Hits            14        14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReubenJ ReubenJ changed the base branch from master to v0.1.x November 14, 2024 16:15
@ReubenJ ReubenJ force-pushed the feat/value-equality branch from 9caac98 to 487e5d5 Compare November 14, 2024 16:17
@ReubenJ ReubenJ changed the base branch from v0.1.x to master November 14, 2024 16:17
@ReubenJ ReubenJ force-pushed the feat/value-equality branch from 487e5d5 to 9c67a1b Compare November 14, 2024 16:18
@ReubenJ ReubenJ marked this pull request as ready for review November 14, 2024 16:18
@ReubenJ ReubenJ force-pushed the feat/value-equality branch 2 times, most recently from 32b0279 to c8d3d1f Compare November 15, 2024 08:24
@ReubenJ ReubenJ force-pushed the feat/value-equality branch from c8d3d1f to 18a03d3 Compare November 15, 2024 08:26
@ReubenJ ReubenJ requested a review from pwochner November 15, 2024 08:27
Copy link

@pwochner pwochner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReubenJ ReubenJ merged commit d30a745 into master Nov 15, 2024
5 checks passed
@ReubenJ ReubenJ deleted the feat/value-equality branch November 15, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement value equality on Problem and MetricProblem
2 participants