Apply BestieTemplate #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenJ
force-pushed
the
apply-less-bestie
branch
from
dcc798a
to
4762bae
Compare
ReubenJ
force-pushed
the
apply-less-bestie
branch
from
4762bae
to
b2821af
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 2 2
Lines 12 12
=======================================
Hits 6 6
Misses 6 6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining our own scripts like in #8,
BestieTemplateoffers us a nicer alternative with a lot more functionality and what I see as sensible defaults. Also, if they update their template in the future, we can apply it to get whatever they added for free.There are probably several defaults from applying the template that are not useful and would need to be fixed. Ex: the README.