CocoaPods 0.17 #50
Merged
CocoaPods 0.17 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ Very nice, thanks! @siuying When you have a chance, would you mind running this against one of your apps? |
|
I having problem building a project:
Usually if i done above I would have build successfully, but this time they just would not build the pods part, as if cocoapod do not exists. |
|
@siuying Can you share your Pods config from your Rakefile? |
|
To be exact, the problem is: when a build failure occurred, even I To reproduce the issue:
Expected result
Actual result
Gemfilesource "http://rubygems.org"
gem "motion-cocoapods", :git => "https://github.com/irrationalfab/motion-cocoapods.git", :ref => "bd3b0ea1449f0d144b0d314c4078502ee0edb0fd"
gem "cocoapods", '0.17.0.rc5'Rakefile# -*- coding: utf-8 -*-
$:.unshift("/Library/RubyMotion/lib")
require 'motion/project'
require 'bundler'
Bundler.require
Motion::Project::App.setup do |app|
# Use `rake config' to see complete project settings.
app.name = 'test'
app.pods do
pod 'QuickDialog'
# pod 'QuickDialog' , :head
end
end |
|
@siuying Great, thanks for the description! |
|
@siuying is the issue only related to building the Pods library? In other, words, is CocoaPods performing an installation before point |
|
it seems not: |
|
The patch was vendoring the Pods project only during installation. @siuying Can you try with the last commit? |
|
Now the pod will always link, but it seems it never update. Even I remove the vendor/Pods/QuickDialog folder and while vendor/build* folders, it never fetch the repo again. I will have to remove whole vendor/Pods folder. |
|
@siuying We've just pushed another fix to CocoaPods: CocoaPods/CocoaPods@a5b8aca. Can you double-check the fix? |
|
I have pushed the patches to a branch https://github.com/HipByte/motion-cocoapods/tree/CocoaPods-0.17. I wanted to run the tests, but my out-of-date RubyMotion is incompatible. If someone can run them, please do. |
|
Ok, I have merged the changes and pushed a 1.3.0.rc1 gem. Please re-open if these issues persist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch performs the following changes
I've not tested an actual installation.
@alloy, @lrz