create-or-update-issue: add action #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
previously approved these changes
Sep 18, 2024
SMillerDev
previously approved these changes
Sep 18, 2024
MikeMcQuaid
reviewed
Sep 18, 2024
|
Sorry, have been a little bit busy this week. I'll get back to this soon.
How about this: we turn this into an action that's able to perform the following depending on
With usage like: - uses: Homebrew/actions/create-issue@master
with:
token: ${{ github.token }}
repository: ${{ github.repository }}
update-existing: true
close-existing: true
dependent-step-conclusion: ${{ steps.deploy.conclusion }}
title: Deployment failed
body: Issue body (or comment to post if issue already exists)
labels: label1,label2
assignees: user1,user2 |
|
@ZhongRuoyu This seems great! |
Bo98
reviewed
Sep 20, 2024
ZhongRuoyu
force-pushed
the
create-issue
branch
2 times, most recently
from
e6931fc to
42a7fa0
Compare
ZhongRuoyu
changed the title
Related: Homebrew/homebrew-core#190657 (comment) Co-authored-by: Sean Molenaar <[email protected]> Co-authored-by: Mike McQuaid <[email protected]> Co-authored-by: Bo Anderson <[email protected]>
ZhongRuoyu
force-pushed
the
create-issue
branch
from
b1b9bf7 to
5b99a85
Compare
MikeMcQuaid
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Looks great, thanks @ZhongRuoyu! After merging: could you update formulae.brew.sh and homebrew/core to use this action and, if you're feeling really generous, add to the Homebrew/brew release workflow that uploads packages 🙇🏻
|
Sure! I'll first do formulae.brew.sh as that's run most frequently. If that works well I'll roll this out to more places. |
ZhongRuoyu
added a commit
to ZhongRuoyu/formulae.brew.sh
that referenced
this pull request
Sep 23, 2024
This was added in Homebrew/actions#588. It simplifies the workflow, and reduces the number of API calls.
ZhongRuoyu
added a commit
to ZhongRuoyu/formulae.brew.sh
that referenced
this pull request
Sep 23, 2024
This was added in Homebrew/actions#588. It simplifies the workflow, and reduces the number of API calls.
ZhongRuoyu
added a commit
to Homebrew/brew
that referenced
this pull request
Sep 24, 2024
This uses the `Homebrew/actions/create-or-update-issue` action added in Homebrew/actions#588 to create an issue when the publish fails for a release. It also automatically updates the issue on repeated failures, and closes the issue when the latest workflow run succeeds.
7 tasks
ZhongRuoyu
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Sep 24, 2024
This was added in Homebrew/actions#588. It can also automatically update an existing issue on repeated failures, or close the issue when the latest workflow run is successful.
ZhongRuoyu
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Sep 24, 2024
This was added in Homebrew/actions#588. It can also automatically update an existing issue on repeated failures, or close the issue when the latest workflow run is successful.
Merged
6 tasks
ZhongRuoyu
added a commit
to Homebrew/rubydoc.brew.sh
that referenced
this pull request
Sep 24, 2024
This was added in Homebrew/actions#588. It simplifies the workflow, and reduces the number of API calls. See also: Homebrew/formulae.brew.sh@f444253.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: Homebrew/homebrew-core#190657 (comment)