feat: Install an unlinked formula via brew install if --overwrite…

… is passed If the intention is to overwrite any existing links, then `brew install` should go on to install over an unlinked formula
Homebrew · Oct 8, 2024 · d55bf34 · d55bf34
1 parent fadca92
commit d55bf34
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/Library/Homebrew/cmd/install.rb b/Library/Homebrew/cmd/install.rb
@@ -289,6 +289,7 @@ def run
             only_dependencies: args.only_dependencies?,
             force:             args.force?,
             quiet:             args.quiet?,
+            overwrite:         args.overwrite?,
           )
         end
 

diff --git a/Library/Homebrew/install.rb b/Library/Homebrew/install.rb
@@ -60,7 +60,8 @@ def install_formula?(
         fetch_head: false,
         only_dependencies: false,
         force: false,
-        quiet: false
+        quiet: false,
+        overwrite: false
       )
         # head-only without --HEAD is an error
         if !head && formula.stable.nil?
@@ -132,7 +133,7 @@ def install_formula?(
                 The currently linked version is: #{formula.linked_version}
               EOS
             end
-          elsif only_dependencies
+          elsif only_dependencies || (!formula.linked? && overwrite)
             msg = nil
             return true
           elsif !formula.linked? || formula.keg_only?

diff --git a/Library/Homebrew/test/cmd/install_spec.rb b/Library/Homebrew/test/cmd/install_spec.rb
@@ -84,4 +84,23 @@ def install
     expect(HOMEBREW_CELLAR/"testball1/0.1/bin/test.dSYM/Contents/Resources/DWARF/test").to be_a_file if OS.mac?
     expect(HOMEBREW_CACHE/"Sources/testball1").to be_a_directory
   end
+
+  it "ignores an unlinked Formula if --overwrite is not passed", :integration_test do
+    install_test_formula "testball1"
+    Formula["testball1"].any_installed_keg.unlink
+
+    expect { brew "install", "testball1" }
+      .to output(/it's just not linked/).to_stderr
+      .and be_a_success
+  end
+
+  it "installs an unlinked Formula if --overwrite is passed", :integration_test do
+    install_test_formula "testball1"
+    Formula["testball1"].any_installed_keg.unlink
+
+    expect { brew "install", "testball1", "--overwrite" }
+      .to output(%r{#{HOMEBREW_CELLAR}/testball1/0\.1}o).to_stdout
+      .and not_to_output.to_stderr
+      .and be_a_success
+  end
 end