Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/url: deprecate url do blocks. #18407

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

MikeMcQuaid
Copy link
Member

We're removing these in Homebrew/homebrew-cask#186501 and forbidding in #18404 so let's deprecate them too (because having functionality like this we don't allow in official taps is recipe for accidental breakage and deprecation later).

We're removing these in
Homebrew/homebrew-cask#186501
so let's deprecate them too.
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, all the other PRs have now been merged and sitting around for several hours

@MikeMcQuaid MikeMcQuaid merged commit f065334 into master Sep 26, 2024
32 checks passed
@MikeMcQuaid MikeMcQuaid deleted the deprecate_cask_url_block branch September 26, 2024 15:16
@MikeMcQuaid
Copy link
Member Author

Thanks @Rylan12!

@mig8447
Copy link

mig8447 commented Oct 8, 2024

How would you go about using HTTP header authentication for downloads without url do?

@gromgit
Copy link
Member

gromgit commented Oct 8, 2024

As the linked PR says:

This PR adds a rubocop check that forbids the use of url do blocks in homebrew/cask. It still allows them to be used in non-official taps.

So nothing changes for third-party taps, really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants