Revert "Deprecate installing casks/formulae from paths." #18436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Also saw a lot of spam with --HEAD and -s runs:
$ brew install -s hello
==> Fetching hello
==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-core/2f982e1
######################################################################### 100.0%
Warning: Calling installing formulae from paths or URLs is deprecated! Use installing formulae from taps instead.
==> Downloading https://ftp.gnu.org/gnu/hello/hello-2.12.1.tar.gz
Already downloaded: /opt/workbrew/home/Library/Caches/Homebrew/downloads/75885520e988c7fe11cd90a933d9fc389e413d5c210aa889325bc61a90c482d4--hello-2.12.1.tar.gz
Warning: Calling installing formulae from paths or URLs is deprecated! Use installing formulae from taps instead.
Warning: Calling installing formulae from paths or URLs is deprecated! Use installing formulae from taps instead.
==> ./configure --disable-silent-rulesThis is because we internally rely on path loading for a lot of things (intentionally). See the ENV.delete("HOMEBREW_FORBID_PACKAGES_FROM_PATHS") we have. (To be clear: that isn't a security hole - paths are considered trusted at the point that happens and we want to be very precise which Ruby file is used for e.g. postinstall.)
|
Thanks for revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew test-botseems to be broken now for third-party taps.Fixes #18433
Reverts #18409