Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkage_checker: skip files with incompatible architectures #18456

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Some formulae include these files, and they can't always be removed.
However, they can cause spurious linkage failures, so let's skip them
when checking for linkage. See, for example, faust at
Homebrew/homebrew-core#191308.

Some formulae include these files, and they can't always be removed.
However, they can cause spurious linkage failures, so let's skip them
when checking for linkage. See, for example, faust at
Homebrew/homebrew-core#191308.
@carlocab carlocab assigned carlocab and unassigned carlocab Sep 28, 2024
@carlocab carlocab requested a review from Bo98 September 28, 2024 21:20
Library/Homebrew/os/linux/elf.rb Show resolved Hide resolved
Library/Homebrew/os/mac/mach.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rather than silently skipping having this files covered by e.g. skip_clean or some other new DSL would be nicer. As-is this seems more likely to increase the times that new formulae bundle e.g. random prebuilt binaries and we don't catch them.

@Bo98
Copy link
Member

Bo98 commented Sep 30, 2024

We already do have an audit and an exception list. This is just to fix a regression in the linkage checker after moving from ldd.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining! Happy to merge.

@carlocab carlocab merged commit f0513c0 into master Sep 30, 2024
27 checks passed
@carlocab carlocab deleted the skip-incompatible-arch branch September 30, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants