Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use requires_ancestor consistently #18521

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Use requires_ancestor consistently #18521

merged 1 commit into from
Oct 7, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Oct 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We've been using requires_ancestor in the runtime since #18102 – let's do so consistently and clear out some unnecessary rbi files.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @dduugg!

@dduugg dduugg merged commit 1a1795f into master Oct 7, 2024
27 checks passed
@dduugg dduugg deleted the runtime-req-ans branch October 7, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants