Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap_auditor: check formulae names in autobump.txt #18541

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 9, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We audit all other formulae lists and this allows identifying when a removed formulae has leftover/outdated references.

In future, may want to refactor autobump handling to give it its own DSL so that we can explicitly label certain formulae as non-autobumped for a specific reason (e.g. upstream autobumps, consistently broken for last bump attempts, etc.)

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea on the DSL. Would love to see that.

@Bo98
Copy link
Member

Bo98 commented Oct 10, 2024

I'm now OK with a DSL now that we have brew bump --auto. It didn't make sense before when it was tied to a random homebrew-core workflow but if we unhide the --auto flag and support it for third-party taps then the DSL makes sense.

@carlocab
Copy link
Member

Alternative suggestion to a DSL: #18227 (comment)

@cho-m cho-m merged commit 3ba4b8d into master Oct 11, 2024
27 checks passed
@cho-m cho-m deleted the audit-autobump branch October 11, 2024 17:24
@cho-m
Copy link
Member Author

cho-m commented Oct 11, 2024

Probably can discuss further either in dedicated issue or whenever anyone gets chance for PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants