Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend/kernel: fix duplicate messages in GitHub Actions #18561

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Calls to opoo and onoe produce duplicate Warning: and Error:
messages in CI logs because we print something to stdout and print an
annotation. Annotations also produce Error: and Warning: lines in
the log.

Let's fix this by skipping printing the message if we've already printed
an annotation.

Calls to `opoo` and `onoe` produce duplicate `Warning:` and `Error:`
messages in CI logs because we print something to stdout and print an
annotation. Annotations also produce `Error:` and `Warning:` lines in
the log.

Let's fix this by skipping printing the message if we've already printed
an annotation.
@MikeMcQuaid
Copy link
Member

Do you have an example of this in the wild?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense!

@MikeMcQuaid MikeMcQuaid merged commit fd270c7 into master Oct 14, 2024
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the duplicate-messages-github-actions branch October 14, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants