add dependencies for Homebrew formulae #2305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses new DSL key
depends_on_brew
.Pursuant to #1992 and relevant to discussion in #2264, it was the request of @phinze on IRC not to add
depends_on
stanzas tobrew-cask.rb
, but to defer dependencies until install-time for individual Casks.This means adding to the DSL so we can specify which Casks have dependencies. I have chosen the key
depends_on_brew
to leave room for specifying dependencies between Casks at a later time. Homebrew will handle the dependency chain if the given dependency has dependencies of its own within Homebrew.I'm not familiar with the test suite at this point. I wouldn't mind some help/pointers on tests for some of my PRs. For this particular case, homebrew's own test suite already has good coverage of the principal functionality.