workflows: attribute workflow dispatcher as commit author

[ZhongRuoyu]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

Resolves #144071.

Since 0f6e602 and subsequently 301a2c6, the author of bottle publish commits has been changed to @BrewTestBot. However, based on feedback on Slack, it is more preferable to attribute the workflow dispatcher as the commit author, since that gives appropriate credit to the maintainer who worked on the bottling.

We can do that by removing the username override in the git-user-config step of the workflow.

homebrew-core/.github/workflows/dispatch-build-bottle.yml

Lines 161 to 165 in a4cbfc8

	- name: Configure Git user
	id: git-user-config
	uses: Homebrew/actions/git-user-config@master
	with:
	username: BrewTestBot

The username defaults to github.actor, the user who triggered the workflow run (in this case, the maintainer who dispatched the workflow run), so that matches our intended behaviour. The action is also capable of handling hidden emails; it constructs the @users.noreply.github.com email if the user's email information is unavaiable from the API.

[Bo98]

The probably want the committer to remain BrewTestBot because we sign the commit as BrewTestBot, but we could change the author (or co-author).

[MikeMcQuaid]

Makes sense to me, thanks @ZhongRuoyu!

[MikeMcQuaid]

Good to merge when @Bo98 is happy.

[Bo98]

When merging, worth monitoring a PR merge and a dispatch bottle upload (not one already queued) to make sure it works as expected.

[ZhongRuoyu]

When merging, worth monitoring a PR merge and a dispatch bottle upload (not one already queued) to make sure it works as expected.

Looks good: #144380

[MikeMcQuaid]

Great work again @ZhongRuoyu!

[ZhongRuoyu]

As a side effect, @github-actions has become the author for automatically-published bottle commits. See, for instance, 3420fb9. Are we okay with that, or do we want @BrewTestBot to author those commits?

[p-linnane]

I'd say having @BrewTestBot be the author would be better, but not sure how much effort it would take to get that sorted out.

[ZhongRuoyu]

I'd say having @BrewTestBot be the author would be better, but not sure how much effort it would take to get that sorted out.

#144738 should do it.