Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/dispatch-build-bottle: set container #186614

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Sep 11, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The setup-homebrew action takes over 4 minutes to finish. Let's speed up the workflow by using our Docker image with Homebrew pre-installed.

@ZhongRuoyu ZhongRuoyu requested review from MikeMcQuaid and a team as code owners September 11, 2024 09:08
The `setup-homebrew` action takes over 4 minutes to finish [^1]. Let's
speed up the workflow by using our Docker image with Homebrew
pre-installed.

[^1]: https://github.com/Homebrew/homebrew-core/actions/runs/10808417105/job/29981362457
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Sep 11, 2024
@ZhongRuoyu ZhongRuoyu force-pushed the dispatch-build-bottle-container branch from 64749ef to 8bee977 Compare September 11, 2024 09:08
@carlocab carlocab added this pull request to the merge queue Sep 11, 2024
Merged via the queue into master with commit 94f28b9 Sep 11, 2024
19 checks passed
@carlocab carlocab deleted the dispatch-build-bottle-container branch September 11, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants