Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: set HOMEBREW_NO_BUILD_ERROR_ISSUES more consistently #188750

Merged
merged 1 commit into from
Sep 13, 2024
Merged

workflows: set HOMEBREW_NO_BUILD_ERROR_ISSUES more consistently #188750

merged 1 commit into from
Sep 13, 2024

Conversation

carlocab
Copy link
Member

Let's do this for every workflow where we build something.

@carlocab
workflows: set HOMEBREW_NO_BUILD_ERROR_ISSUES more consistently
00d5e5d 
Let's do this for every workflow where we build something.
@carlocab carlocab requested review from MikeMcQuaid and a team as code owners September 13, 2024 03:42
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 13, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Sep 13, 2024
@carlocab carlocab enabled auto-merge September 13, 2024 04:03
Bo98
Bo98 approved these changes Sep 13, 2024
View reviewed changes
.github/workflows/tests.yml Show resolved Hide resolved
@carlocab carlocab added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit bdd3ece Sep 13, 2024
20 checks passed
@carlocab carlocab deleted the more-no-build-error-issues branch September 13, 2024 06:24
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @carlocab!

I have a dream that one day "all the workflows where we build something" would be a single workflow...

@carlocab
Copy link
Member Author

I have a dream that one day "all the workflows where we build something" would be a single workflow...

One is a tall order. Two seems doable.

@MikeMcQuaid
Copy link
Member

@carlocab in my mind the tests workflow could take the combined inputs of the dispatch workflow(s) and adjust behaviour accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@MikeMcQuaid MikeMcQuaid Awaiting requested review from MikeMcQuaid MikeMcQuaid is a code owner

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. workflows PR modifies GitHub Actions workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlocab @MikeMcQuaid @Bo98