recc 1.2.21 #191819

sakeeb · 2024-09-25T01:27:25Z

RECC is a compiler launcher that caches the results on compilation and link command, and optionally forward them to a remote execution service.

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

github-actions · 2024-09-25T01:31:18Z

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

carlocab

Thanks for the PR. A few suggestions.

Formula/r/recc.rb

sakeeb · 2024-09-26T15:07:43Z

@carlocab, thank you for your detailed review. It really helped to trim down a lot of unnecessary content.

I have addressed all the review comments. I included caveat about usage that is specific to installation using Homebrew formula. I noticed a similar caveat is used for ccache.

RECC is a compiler launcher that caches the results on compilation and link command, and optionally forward them to a remote execution service. Remove running launchctrl command in caveat Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> recc 1.2.21 Address review comments recc 1.2.21 tests Added tests to start recc-server and run recc-cc command twice. The second run should result in a cache hit. Update test case Update test Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> recc 1.2.21: Update user configuration location Use etc as location for system wide recc.conf location. In the absense of the etc/recc.conf, a default configuration installed in prefix/etc/recc/recc.conf will be used. recc 1.2.21 Add caveat about how to invoke compiler using recc. The instructions in caveat is specific to how homebrew is configured Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <[email protected]> recc 1.2.24 Update version Use wrapper scripts from the upstream project

SMillerDev · 2024-10-12T08:43:47Z

Dropped the merge commit, this should now be ready for review again

MikeMcQuaid

Thanks @sakeeb, great work (and patience) here. All comments can be addressed in follow-up releases/PRs. You rock!

MikeMcQuaid · 2024-10-13T16:43:26Z

Formula/r/recc.rb

+    ENV["RECC_BIN"] = bin/"recc"
+    system "command envsubst < scripts/wrapper-templates/recc-c++.in > recc-c++"
+    system "command envsubst < scripts/wrapper-templates/recc-cc.in > recc-cc"
+    bin.install "recc-c++"
+    bin.install "recc-cc"


A make install for this would be nice to have.

MikeMcQuaid · 2024-10-13T16:43:32Z

Formula/r/recc.rb

+    system "command envsubst < scripts/wrapper-templates/recc.conf.in > recc.conf"
+    etc.install "recc.conf"
+
+    bin.install "scripts/wrapper-templates/casd-helper" => "recc-server"


MikeMcQuaid · 2024-10-13T16:43:52Z

Formula/r/recc.rb

+    <<~EOS
+      To launch a compiler with recc, set the following variables:
+        CC=#{opt_bin}/recc-cc
+        CXX=#{opt_bin}/recc-c++
+    EOS


Are these Homebrew specific caveats?

MikeMcQuaid · 2024-10-13T16:44:17Z

Formula/r/recc.rb

+    # Override default values of server and log_level
+    ENV["RECC_SERVER"] = "unix://#{recc_cache_dir}/casd.sock"
+    ENV["RECC_LOG_LEVEL"] = "info"
+    recc_test=[bin/"recc-cc", "-c", test_file]


Suggested change

recc_test=[bin/"recc-cc", "-c", test_file]

recc_test = [bin/"recc-cc", "-c", test_file]

github-actions · 2024-10-13T16:58:47Z

@MikeMcQuaid has requested bottles to be published to this PR.

github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 25, 2024

carlocab reviewed Sep 25, 2024

View reviewed changes

github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 25, 2024

sakeeb force-pushed the recc branch from c87d230 to 4f050f7 Compare September 25, 2024 03:11

github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Sep 25, 2024

sakeeb force-pushed the recc branch from c280147 to 9cb484d Compare September 25, 2024 03:20

github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Sep 25, 2024

sakeeb force-pushed the recc branch from db35cb0 to 5d53f99 Compare September 25, 2024 13:15

github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 25, 2024

carlocab reviewed Sep 25, 2024

View reviewed changes

Formula/r/recc.rb Outdated Show resolved Hide resolved

sakeeb force-pushed the recc branch from 5d53f99 to a220100 Compare September 25, 2024 14:40

carlocab reviewed Sep 25, 2024

View reviewed changes

Formula/r/recc.rb Outdated Show resolved Hide resolved

github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 25, 2024

sakeeb force-pushed the recc branch 2 times, most recently from bd370df to 699e2df Compare September 26, 2024 01:29

github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Sep 26, 2024

sakeeb force-pushed the recc branch from 52039e1 to d8e57ca Compare September 26, 2024 01:59

github-actions bot added long build Set a long timeout for formula testing autobump new formula PR adds a new formula to Homebrew/homebrew-core and removed new formula PR adds a new formula to Homebrew/homebrew-core autobump labels Sep 27, 2024

sakeeb force-pushed the recc branch from 134e70f to 4a3c2d3 Compare September 27, 2024 01:40

github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 27, 2024

github-actions bot added autobump and removed new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 3, 2024

sakeeb changed the title ~~recc 1.2.20~~ recc 1.2.21 Oct 3, 2024

sakeeb force-pushed the recc branch from ebd81f2 to e0a9ed6 Compare October 3, 2024 03:31

github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core and removed automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. autobump labels Oct 3, 2024

sakeeb marked this pull request as draft October 3, 2024 13:52

sakeeb force-pushed the recc branch from e0a9ed6 to c529445 Compare October 11, 2024 17:49

sakeeb marked this pull request as ready for review October 11, 2024 17:49

github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 12, 2024

SMillerDev force-pushed the recc branch from 333d62c to 372bf26 Compare October 12, 2024 08:43

github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 12, 2024

SMillerDev requested review from MikeMcQuaid and carlocab October 12, 2024 08:43

MikeMcQuaid approved these changes Oct 13, 2024

View reviewed changes

MikeMcQuaid enabled auto-merge October 13, 2024 16:44

MikeMcQuaid added this pull request to the merge queue Oct 13, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 13, 2024

recc: add 1.2.24 bottle.

e0e31f7

github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 13, 2024

github-actions bot approved these changes Oct 13, 2024

View reviewed changes

BrewTestBot enabled auto-merge October 13, 2024 16:59

BrewTestBot added this pull request to the merge queue Oct 13, 2024

Merged via the queue into Homebrew:master with commit 41168b2 Oct 13, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

recc 1.2.21 #191819

recc 1.2.21 #191819

sakeeb commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

carlocab left a comment

sakeeb commented Sep 26, 2024 •

edited

Loading

SMillerDev commented Oct 12, 2024

MikeMcQuaid left a comment

MikeMcQuaid Oct 13, 2024

MikeMcQuaid Oct 13, 2024

MikeMcQuaid Oct 13, 2024

MikeMcQuaid Oct 13, 2024

github-actions bot commented Oct 13, 2024

	recc_test=[bin/"recc-cc", "-c", test_file]
	recc_test = [bin/"recc-cc", "-c", test_file]

recc 1.2.21 #191819

recc 1.2.21 #191819

Conversation

sakeeb commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

carlocab left a comment

Choose a reason for hiding this comment

sakeeb commented Sep 26, 2024 • edited Loading

SMillerDev commented Oct 12, 2024

MikeMcQuaid left a comment

Choose a reason for hiding this comment

MikeMcQuaid Oct 13, 2024

Choose a reason for hiding this comment

MikeMcQuaid Oct 13, 2024

Choose a reason for hiding this comment

MikeMcQuaid Oct 13, 2024

Choose a reason for hiding this comment

MikeMcQuaid Oct 13, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 13, 2024

sakeeb commented Sep 26, 2024 •

edited

Loading