workflows/actionlint: run zizmor

[carlocab]

This tool, written by a certain @woodruffw, seems like it would be useful.

See https://github.com/woodruffw/zizmor.

Needs #195936.

[woodruffw]

For viz: woodruffw/zizmor#57 will make the SARIF output slightly friendlier for GitHub's SARIF support once fixed. Right now the SARIF results are well-formed and uploaded correctly, but don't rebase correctly on top of the repo root.

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[woodruffw]

LGTM behaviorally. I leave it up to you whether you'd prefer I fix woodruffw/zizmor#57 before merging here or not -- the results will show up as is, but won't be as easy to relate to existing files until that's fixed 🙂

[carlocab]

Dropped HOMEBREW_NO_INSTALL_FROM_API to avoid erroring out when these formulae are updated.

I leave it up to you whether you'd prefer I fix woodruffw/zizmor#57 before merging here or not -- the results will show up as is, but won't be as easy to relate to existing files until that's fixed 🙂

May also just wait until this is fixed.

[woodruffw]

I've released v0.1.3, which contains the SARIF fix.

Example render:

https://github.com/woodruffw/zizmor/security/code-scanning/2

[carlocab]

Can't see, but we can re-run actionlint / zizmor after #196022 has hit the API.

[woodruffw]

Ah, whoops. Here's a cap:

(There's still lots of room for improvement there.)

[carlocab]

Cool. Let's give this a try. There are a lot of warnings though -- many of them would be difficult to address.

[carlocab]

Something that would be nice to fix is that the output on GitHub isn't quite as nice as on the command-line. For example:

https://github.com/Homebrew/homebrew-core/security/code-scanning/34

Compare this with:

warning[artipacked]: credential persistence through GitHub Actions artifacts
   --> /opt/homebrew/Library/Taps/homebrew/homebrew-core/.github/workflows/tests.yml:147:9
    |
147 |       - uses: actions/checkout@v4
    |         ------------------------- does not set persist-credentials: false
    |

On GitHub you don't see the recommendation to set persist-credentials: false.

[woodruffw]

Something that would be nice to fix is that the output on GitHub isn't quite as nice as on the command-line. For example:

Yep, this is tracked with woodruffw/zizmor#66. I'll try and fix that with the next release.