ci: use ubuntu-latest

[iMichka]

Align CI setup with what has been done in Homebrew/brew#18704
Use ubuntu-latest when the ubuntu version does not matter.
ubuntu-latest is equivalent to 22.04 right now so this does not change anything

Our ubuntu 22.04 docker image is still used (this has not been modified)

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[iMichka]

Moving to draft, I realised there is some other code here that hard-codes the runner name: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/dev-cmd/dispatch-build-bottle.rb#L68

We will have to make a change in brew too. Wondering if there is a way to make this slightly more robust (and not having to look at two different places for that logic).

[Bo98]

We will have to make a change in brew too. Wondering if there is a way to make this slightly more robust (and not having to look at two different places for that logic).

Anything that's strictly Homebrew/core specific should generally live in Homebrew/core (like brew determine-rebottle-runners is). brew dispatch-build-bottle was generalised enough to work with third-party taps due to the --tap= and --workflow= arguments.

However dispatch-build-bottle doesn't setup a Docker container so it probably shouldn't be changed for the reason of third-party taps. We made container setup Homebrew/core specific and do it within the workflow itself.

[iMichka]

We will have to make a change in brew too. Wondering if there is a way to make this slightly more robust (and not having to look at two different places for that logic).

Anything that's strictly Homebrew/core specific should generally live in Homebrew/core (like brew determine-rebottle-runners is). brew dispatch-build-bottle was generalised enough to work with third-party taps due to the --tap= and --workflow= arguments.

However dispatch-build-bottle doesn't setup a Docker container so it probably shouldn't be changed for the reason of third-party taps. We made container setup Homebrew/core specific and do it within the workflow itself.

Makes sense, thanks for the explanation.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[iMichka]

Merging as this got approved. Let's see how this goes.