Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with 1.8 Insiders #70

Closed
bfulop opened this issue Nov 15, 2016 · 4 comments
Closed

Compatibility with 1.8 Insiders #70

bfulop opened this issue Nov 15, 2016 · 4 comments

Comments

@bfulop
Copy link

bfulop commented Nov 15, 2016

Hello,

Is it possible that Beautify is not yet compatible with the 1.8 Insiders version (as of 15th November)?

I'm syncing my Code setup between 1.7 and 1.8 so the settings etc. are the same between 1.7 and 1.8.
In 1.7 Beautify works great, however in 1.8, format on save doesn't work. If I launch the beautify command manually, Beautify is asking me each time to select the file type (JS/CSS/HTML) even for a simple js or css files.

So my guess is that in 1.8 it doesn't recognise the file types correctly?

@HookyQR
Copy link
Owner

HookyQR commented Nov 15, 2016

I'll have to pull the insiders build to have a look. Hackdays at work tomorrow, so I'll have plenty of time.

@HookyQR
Copy link
Owner

HookyQR commented Nov 16, 2016

This is a regression error at the VS code end, but I'll change the setting lookup mechanism to get around the current failure incase it isn't fixed.

@HookyQR
Copy link
Owner

HookyQR commented Nov 16, 2016

Fixed in 0.5.5.

@HookyQR HookyQR closed this as completed Nov 16, 2016
@bfulop
Copy link
Author

bfulop commented Nov 16, 2016

Thank you HookyQR for fixing this so quickly, even if the bug didn't come from your end!

I can confirm, beautify is working perfectly on 1.8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants