Add/button hover states #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 8, 2023 10:15
add spacing options to form button. This brings the form button in alignment with the theme settings that are in place on generic buttons
jazzyclimber
added
good first issue
enhancement
jasonnrosa
reviewed
Feb 9, 2023
src/fields.json
Outdated
| ] | ||
| } | ||
| ], | ||
| "default": {} |
There was a problem hiding this comment.
Nit thing - can we 🪓 this default given it is blank?
jasonnrosa
approved these changes
Feb 9, 2023
added 2 commits
February 9, 2023 10:33
Looks like there were a bunch of blank default key/val pairs. They are now blasted away by the power of oxy-clean.
Looks like there were a bunch of blank default key/val pairs. They are now blasted away by the power of oxy-clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change
Description
Added various settings to theme fields.json and theme-overrides.css to bring some congruency between related sections and their options. (Ie button settings && form submit button settings)
Checklist
People to notify
@jasonnrosa @bran-van-d @joeyblake
(Still getting the hang of how to request reviewers for these PR's. I added Jason in the reviewers section on the top right and tagged everyone here. Let me know if there is a better workflow.)