Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some MCU commands are used inefficiently #18

Closed
mrnuke opened this issue Jul 6, 2022 · 1 comment
Closed

Some MCU commands are used inefficiently #18

mrnuke opened this issue Jul 6, 2022 · 1 comment

Comments

@mrnuke
Copy link
Collaborator

mrnuke commented Jul 6, 2022

The following MCU commands take a list of ports:

  • 10 - poe_cmd_port_detection_type()
  • 11 - poe_cmd_port_classification()
  • 13 - poe_cmd_port_disconnect_type()
  • 15 - poe_cmd_port_power_limit_type()
  • 16 - poe_cmd_port_power_budget()
  • 1A - poe_set_port_priority()
  • 1C - poe_set_port_power_up_mode()

realtek-poe is sending only one port per command. The issue is we're sending up to 192 config packets for a 24-switch port. That could drop to 66 by shoving more than one port per packet. I suspect this might help with #10 and #13.

Further optimizations

  • poe_cmd_port_detection_type() and poe_cmd_port_disconnect_type() can also use 0x7f to signal all ports.
  • The trace that I have for 1900 ZyXEL GS1900-24HPv1 doesn't make use of 00, 10, 11, or 13.
@mrnuke
Copy link
Collaborator Author

mrnuke commented Jul 19, 2022

FIxed by #19

@mrnuke mrnuke closed this as completed Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant