From 4b200198a20b76857b9b032c5c8cfb0661c7fd12 Mon Sep 17 00:00:00 2001
From: Thomas <thomas.lapiana+github@pm.me>
Date: Wed, 9 Aug 2023 22:18:42 +0800
Subject: [PATCH] Fix PyYAML Checks (#145)

* Fix PyYAML Checks

* fix: test another fix

* fix: add the Cython pin to the static checks

* fix: add the fix to the tests

* docs: changelog
---
 .github/workflows/pr_checks.yml | 18 ++++++++++++++++++
 CHANGELOG.md                    |  1 +
 2 files changed, 19 insertions(+)

diff --git a/.github/workflows/pr_checks.yml b/.github/workflows/pr_checks.yml
index e55df30b..45046390 100644
--- a/.github/workflows/pr_checks.yml
+++ b/.github/workflows/pr_checks.yml
@@ -50,6 +50,12 @@ jobs:
           python-version: "3.10.11"
           cache: "pip"
 
+      - name: Pin Cython
+        run: |
+          echo 'Cython < 3.0' > /tmp/constraint.txt
+          PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
+          pip install 'PyYAML==5.4.1'
+
       - name: Install Package
         run: pip install .
 
@@ -72,6 +78,12 @@ jobs:
           python-version: ${{ env.DEFAULT_PYTHON_VERSION }}
           cache: "pip"
 
+      - name: Pin Cython
+        run: |
+          echo 'Cython < 3.0' > /tmp/constraint.txt
+          PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
+          pip install 'PyYAML==5.4.1'
+
       - name: Install Nox
         run: pip install nox
 
@@ -96,6 +108,12 @@ jobs:
           python-version: ${{ matrix.python_version }}
           cache: "pip"
 
+      - name: Pin Cython
+        run: |
+          echo 'Cython < 3.0' > /tmp/constraint.txt
+          PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
+          pip install 'PyYAML==5.4.1'
+
       - name: Install Nox
         run: pip install nox
 
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4ed705d6..01485224 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@ The types of changes are:
 ### Fixed
 
 - Don't allow duplicate entries for DatasetCollections as part of Datasets [#136](https://github.com/ethyca/fideslang/pull/136)
+- Cython/PyYAML versions breaking builds [#145](https://github.com/ethyca/fideslang/pull/145)
 
 ## [1.4.3](https://github.com/ethyca/fideslang/compare/1.4.2...1.4.3)