From 1c454ea1a9b432cbfb39aeca631c4a37d1293284 Mon Sep 17 00:00:00 2001
From: -isum <17521736+equt@users.noreply.github.com>
Date: Thu, 6 Apr 2023 17:13:34 +0800
Subject: [PATCH] fix(compiler-sfc): accept `StringLiteral` node in
 `defineEmit` tuple syntax (#8041)

close #8040
---
 .../__snapshots__/compileScript.spec.ts.snap     | 16 ++++++++++++++++
 .../compiler-sfc/__tests__/compileScript.spec.ts | 11 +++++++++++
 packages/compiler-sfc/src/compileScript.ts       | 10 +++++++---
 3 files changed, 34 insertions(+), 3 deletions(-)

diff --git a/packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snap b/packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snap
index 818ea02e303..23a3741afb2 100644
--- a/packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snap
+++ b/packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snap
@@ -1457,6 +1457,22 @@ export default /*#__PURE__*/_defineComponent({
 
       
       
+return { emit }
+}
+
+})"
+`;
+
+exports[`SFC compile <script setup> > with TypeScript > defineEmits w/ type (property syntax string literal) 1`] = `
+"import { defineComponent as _defineComponent } from 'vue'
+
+export default /*#__PURE__*/_defineComponent({
+  emits: [\\"foo:bar\\"],
+  setup(__props, { expose: __expose, emit }) {
+  __expose();
+
+      
+      
 return { emit }
 }
 
diff --git a/packages/compiler-sfc/__tests__/compileScript.spec.ts b/packages/compiler-sfc/__tests__/compileScript.spec.ts
index 7187c5d3191..1d8d20ec1a0 100644
--- a/packages/compiler-sfc/__tests__/compileScript.spec.ts
+++ b/packages/compiler-sfc/__tests__/compileScript.spec.ts
@@ -1629,6 +1629,17 @@ const emit = defineEmits(['a', 'b'])
       assertCode(content)
     })
 
+    // #8040
+    test('defineEmits w/ type (property syntax string literal)', () => {
+      const { content } = compile(`
+      <script setup lang="ts">
+      const emit = defineEmits<{ 'foo:bar': [] }>()
+      </script>
+      `)
+      expect(content).toMatch(`emits: ["foo:bar"]`)
+      assertCode(content)
+    })
+
     describe('defineSlots()', () => {
       test('basic usage', () => {
         const { content } = compile(`
diff --git a/packages/compiler-sfc/src/compileScript.ts b/packages/compiler-sfc/src/compileScript.ts
index 8d22d7e1348..31114c52d8c 100644
--- a/packages/compiler-sfc/src/compileScript.ts
+++ b/packages/compiler-sfc/src/compileScript.ts
@@ -2316,11 +2316,15 @@ function extractRuntimeEmits(
         hasCallSignature = true
       }
       if (t.type === 'TSPropertySignature') {
-        if (t.key.type !== 'Identifier' || t.computed) {
+        if (t.key.type === 'Identifier' && !t.computed) {
+          emits.add(t.key.name)
+          hasProperty = true
+        } else if (t.key.type === 'StringLiteral' && !t.computed) {
+          emits.add(t.key.value)
+          hasProperty = true
+        } else {
           error(`defineEmits() type cannot use computed keys.`, t.key)
         }
-        emits.add(t.key.name)
-        hasProperty = true
       }
     }
     if (hasCallSignature && hasProperty) {