Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

svg icons with circles (wrapped or solid) seem blurry on retina displays #12

Open
barlock opened this issue Nov 10, 2015 · 4 comments
Open
Assignees

Comments

@barlock
Copy link
Contributor

barlock commented Nov 10, 2015

This is strange because svgs are supposed to fix this problem.

I think its because the circles around the icons are made with a element instead of a which they should be so the browser can figure out the most optimal way to layout the pixels rather than specifying them exactly

https://github.com/IBM-Design/icons/blob/master/svg/action-based/add-new_32.svg?short_path=5b81d52#L8 Add new icons "circle"

image
^ example. Visible pixels on my thunderbolt display

@barlock
Copy link
Contributor Author

barlock commented Nov 10, 2015

I think these icons also suffer from sub-pixel problems. github released a great article on the development of the Octicons that discusses this.

@thundernixon
Copy link

SVGs can solve this problem to a large degree, but when it comes down to it, curves and diagonal lines are still subject to the limitations of pixel rendering – whereas straight lines can exactly use whole pixels, curves require zig zags and subpixel rendering. So, even GitHub's Octicons have straight edges which are crisper than the curved lines (check out the notifications bell at the top of the GitHub UI).

@barlock
Copy link
Contributor Author

barlock commented Dec 8, 2015

Totally, but I think we can be doing better. If an svg icon is made well it should look crisp when resized, all of the circles in the icon library don't. I'm not sure what the right solution to the problem is. It's possible that that page is using an icon designed to be much smaller and blown up to be bigger but I doubt it. I'll check and see if that is the case.

@seejamescode
Copy link
Collaborator

Let me know what your view is on this issue is now please!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants