-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI build steps #190
Labels
Comments
We will need to drop support for 1.2 as well when we merge #156. |
Let's drop 1.1. once we add 1.4 (which should be out December 1st) so we keep the last three stable releases. |
|
We tackled all the golint suggestions we want to fi. Because there's many suggestions that we're not willing to tackle, we should not make it part of CI, but just run it every now and then. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
go fmt
- see Addgo fmt
to build #196go vet
- see Addgo vet
as build step #195 - requires dropping support for go 1.1go lint
- see Address some golint suggestions #194 for initial fixes.errcheck
- requires some fixes toBroker.Open
callsgo test -race
- see Fix test raciness #189@eapache
The text was updated successfully, but these errors were encountered: