Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build steps #190

Closed
5 tasks done
wvanbergen opened this issue Nov 16, 2014 · 4 comments
Closed
5 tasks done

CI build steps #190

wvanbergen opened this issue Nov 16, 2014 · 4 comments

Comments

@wvanbergen
Copy link
Contributor

@eapache

@eapache
Copy link
Contributor

eapache commented Nov 16, 2014

We will need to drop support for 1.2 as well when we merge #156.

@eapache
Copy link
Contributor

eapache commented Nov 16, 2014

Let's drop 1.1. once we add 1.4 (which should be out December 1st) so we keep the last three stable releases.

@wvanbergen
Copy link
Contributor Author

  • go test -race has been merged.
  • PR is open for go vet (Add go vet as build step #195)
  • Initial fixes for go lint: Address some golint suggestions #194 Do we want to address everything it suggests?
  • errcheck gives us some warning about broker.Open, which can return errors. We'll have to address these if we want to include them in the build process.

@wvanbergen wvanbergen changed the title CI build settings CI build steps Nov 16, 2014
@wvanbergen
Copy link
Contributor Author

We tackled all the golint suggestions we want to fi. Because there's many suggestions that we're not willing to tackle, we should not make it part of CI, but just run it every now and then. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants