Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CodeQL scanning? #1924

Closed
dnwe opened this issue Apr 28, 2021 · 2 comments
Closed

Enable CodeQL scanning? #1924

dnwe opened this issue Apr 28, 2021 · 2 comments

Comments

@dnwe
Copy link
Collaborator

dnwe commented Apr 28, 2021

@bai thoughts on enabling https://github.com/Shopify/sarama/security/code-scanning? I haven't much personal experience of the CodeQL analysis of Go projects https://github.com/github/codeql-go compared with what we already get from golangci-lint and staticcheck, but it seems like it wouldn't hurt and could have additional useful coverage
@bai bai mentioned this issue Apr 28, 2021
Merged
@bai
Copy link
Contributor

bai commented Apr 28, 2021

This is a great idea! Submitted a PR to test things out - let me know what you think 🙏🏼

@dnwe
Copy link
Collaborator Author

dnwe commented Apr 28, 2021

Thanks, working well and clean bill of health on master now https://github.com/Shopify/sarama/security/code-scanning

@dnwe dnwe closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bai @dnwe