Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not supported KIP-368: Allow SASL Connections to Periodically Re-Authenticate #2060

Closed
ppatierno opened this issue Nov 4, 2021 · 5 comments

Comments

@ppatierno
Copy link

ppatierno commented Nov 4, 2021

Hi,
it seems that Sarama doesn't support KIP-368 which is about re-authenticating when on the broker the connections.max.reauth.ms is set as timeout.
Right now Sarama is able to handle the disconnection and reconnecting, even if it works for producer and consumer but not for the admin client as reported by #2042.
Is there any plan/roadmap to add this feature to future Sarama version?

@dnwe
Copy link
Collaborator

dnwe commented Apr 13, 2022

@ppatierno this should now be available on main thanks to @k-wall and will be in the next upcoming release version of Sarama

@ppatierno
Copy link
Author

@dnwe @k-wall thanks! that's great!

@bodypumper
Copy link

@dnwe Hi, when will the new version be released about this issue?

@fikersd
Copy link

fikersd commented Dec 6, 2022

refresh client controller before attempting to operate kafka ACL.
`client, err := sarama.NewClient([]string{"localhost:9092"}, sarama.NewConfig())
if err != nil {
panic(err)
}

for {
if _, err := client.RefreshController(); err != nil {
panic(err)
}
admin, err := sarama.NewClusterAdminFromClient(client)
if err != nil {
panic(err)
}
if err := admin.CreateACLs([]*sarama.ResourceAcls{
// TODO: your acl resources
}); err != nil {
panic(err)
}
log.Println("create acls ...")
time.Sleep(time.Minute * 30)
}
`

@k-wall
Copy link
Contributor

k-wall commented Jun 22, 2023

Hi, @dnwe I think this issue is closeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants