Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snappy dependency moved again #490

Closed
aaronbee opened this issue Jul 21, 2015 · 5 comments
Closed

Snappy dependency moved again #490

aaronbee opened this issue Jul 21, 2015 · 5 comments

Comments

@aaronbee
Copy link
Contributor

The snappy dependency has moved from

github.com/golang/snappy/snappy
to
github.com/golang/snappy

golang/snappy@7a15765

This is breaking go get of sarama
@mblair
Copy link

mblair commented Jul 21, 2015

I'm not a maintainer, but this has already been fixed on master:

#486

@aaronbee
Copy link
Contributor Author

Oops, missed that. Thanks @mblair

Can that change be ported to the version of sarama that gopkg.in/Shopify/sarama.v1 points to?

Thanks,
Aaron

@eapache
Copy link
Contributor

eapache commented Jul 21, 2015

I will release 1.4.3 (hopefully) tomorrow with this change, I just have a bit of misc. stuff to tidy up first.

@eapache
Copy link
Contributor

eapache commented Jul 21, 2015

1.4.3 released with this change and a few others.

@eapache eapache closed this as completed Jul 21, 2015
@tnolet tnolet mentioned this issue Jul 22, 2015
Closed
@tnolet
Copy link

tnolet commented Jul 22, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mblair @aaronbee @eapache @tnolet