Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torchgeo models #233

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Add torchgeo models #233

wants to merge 40 commits into from

Conversation

paolofraccaro
Copy link
Collaborator

Added different models as implemented in torchgeo. Added a related test file and passing all other tests. Only issue is mmseg installation imcompatible with updated version of timm.

@paolofraccaro paolofraccaro linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is terratorch.datasets.sen1floods11_lat_lon.Sen1Floods11NonGeo going to replace terratorch.datasets.sen1floods11.Sen1Floods11NonGeo ? Or should we keep both ?

Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Copy link
Member

By running the automatic tests pytest -s tests/test_encoder_decoder_torchgeo_models.py::test_create_pixelwise_model_dofa, I see the error:
FAILED tests/test_encoder_decoder_torchgeo_models.py::test_create_pixelwise_model_dofa[True-IdentityDecoder-segmentation-expected1-dofa_large_patch16_224] - AttributeError: 'DOFA' object has no attribute 'embed_dim'
In fact, the dofa model here:
terratorch/models/backbones/dofa_vit.py:64: in init
self.out_channels = [self.dofa_model.embed_dim] * len(self.out_indices)
has no attribute called embed_dim.
I'm using timm==0.9.7 and Python 3.12.

Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Copy link
Member

Should we replace the current torchgeo version from requirements and pyproject.toml by:
torchgeo @ git+https://github.com/microsoft/torchgeo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add torchgeo pretrained backbones/FMs
3 participants