Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): 194 - Fixed LengthMeasurement bug while UI Disabled. #199

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

HoyosJuan
Copy link
Member

Description

This PR solves issue #194. The problem was the VertexPicker was taking the viewer container from the UI Manager, but the UI Manager never gets initialized if the developer decides to disable the built-in UI by using components.uiEnabled = false.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HoyosJuan HoyosJuan added the bug Something isn't working label Dec 1, 2023
@HoyosJuan HoyosJuan added this to the 1.3.0 milestone Dec 1, 2023
@HoyosJuan HoyosJuan merged commit 76bc216 into ThatOpen:main Dec 1, 2023
1 check passed
@HoyosJuan HoyosJuan deleted the 194-uimanager-bug branch December 1, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant