Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional description id extension #624

Open
danka74 opened this issue Sep 20, 2024 · 5 comments
Open

Add optional description id extension #624

danka74 opened this issue Sep 20, 2024 · 5 comments
Assignees

Comments

@danka74
Copy link
Contributor

danka74 commented Sep 20, 2024

I had the need for adding description ids to ValueSet $expand result. The use case was to use FHIR $expand output as a basis for making batch description change requests to the SNOMED authoring platform. Also, there is a standard extension for description ids: https://build.fhir.org/ig/HL7/fhir-extensions//StructureDefinition-coding-sctdescid.html

There is a working branch in my fork: https://github.com/danka74/snowstorm/tree/description-ids
but would require unit tests and documentation.

The implementation adds a new parameter to the $expand operation definition "includeDescriptionId" which if it's =true adds the extension above to the FHIR expansion results.

Cheers,
Daniel

@kaicode
Copy link
Member

kaicode commented Sep 20, 2024

Thanks Daniel, this looks good.
We will take this when we can.

@kaicode kaicode self-assigned this Sep 20, 2024
@kaicode
Copy link
Member

kaicode commented Sep 20, 2024

Is there a standard for the request parameter name? The fork uses includeDescriptionId.

@kaicode
Copy link
Member

kaicode commented Sep 20, 2024

(Internal ticket ISTO-124 )

@danka74
Copy link
Contributor Author

danka74 commented Sep 20, 2024

I don't think there is a standard parameter name, and something like x-include-description-id could be an option which more clearly states it's a non-standard parameter.

Further, I can go ahead and create unit tests and documentation.

@kaicode
Copy link
Member

kaicode commented Sep 24, 2024

That new suggested parameter name looks good to me.
Please do add tests and documentation if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants