Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved issue_13 Animation to Hamburger menu and design it in mobile view #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

disvid
Copy link
Collaborator

@disvid disvid commented Dec 19, 2024

Related Issue

Closes #13

Type of Change

Put x inside the square bracket to specify what type of change your PR is:

  • New Feature
  • Bug Fix
  • Code Refactor
  • Documentation Update
  • Other (please specify):

Description of Change

converts the bars icon of hamburger menu to cross icon on opening it.

Implementation Details

required transformations have been fone in the css and js codes.

Demo

Screenshot (10)
Screenshot (9)

@disvid

This comment was marked as resolved.

@sasmitaditya13
Copy link
Collaborator

@disvid You also need to add animation to the way it opens. There may be an animation present in the figma file. If there isn't then think of some animation and get it approved.

@disvid
Copy link
Collaborator Author

disvid commented Jan 8, 2025

@sasmitaditya13 added the animation.

@sasmitaditya13
Copy link
Collaborator

@Yash-g2310 review this

@Yash-g2310
Copy link
Collaborator

@disvid there are some issues
firstly, see the video

hb.mp4

here the "now sell your product hassle free" part moves down which is not good, the hamburger menu should be overlayed on screen,
secondly, also try to design the hamburger menu, you can design it as you want but try to keep it minimalistic so that it blends with the design, not stands out,

also before working on the changes make sure to fetch the latest changes from upstream

@Yash-g2310
Copy link
Collaborator

Yash-g2310 commented Jan 17, 2025

@disvid also i just found out the cross is not removed if we open the hamburger then switch so desktop view, please also correct it

hb2.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animation to Hamburger menu and design it in mobile view
3 participants