Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inline style in HTML and added it to CSS #23 #49

Closed
wants to merge 1 commit into from

Conversation

Akshat1276
Copy link
Collaborator

@Akshat1276 Akshat1276 commented Dec 17, 2024

Related Issue

Closes #23

Type of Change

  • New Feature
  • Bug Fix
  • Code Refactor
  • Documentation Update
  • Other (please specify):

Description of Change

Removed inline style in HTML found in <div class="abc"> and <div class="ijk"> and added it to CSS

###Demo

before
image
image
image
image

after
image
image
image
image

@Hardik-2311
Copy link
Collaborator

@Akshat1276 Could you please share a screenshot of your screen after making the changes, demonstrating the desired behavior?

@Akshat1276
Copy link
Collaborator Author

Akshat1276 commented Dec 20, 2024

@Hardik-2311 Shared the screenshots sir.

Copy link
Collaborator

@Yash-g2310 Yash-g2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akshat1276 i have mentioned the change required
image
as you can see without it it is creating a bit of a mess
please change this asap
if any doubt head to easysell discord

<div class="def"> +91 4206969420</div>
<div class="abc"><a href="#"><i class="fa fa-2x fa-envelope" class="contact"
style="color: #F6FFFA;"></i></a></div>
<div class="abc"><a href="#"><i class="fa fa-2x fa-en></i></a></div>
Copy link
Collaborator

@Yash-g2310 Yash-g2310 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Akshat1276 there is a small problem with your commits
there is a missing ' " ' here and the class name is also not set properly (match with the actual code)

@Yash-g2310
Copy link
Collaborator

solved by someone else, thanks for contributing !

@Yash-g2310 Yash-g2310 closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove inline style and add it to css
3 participants