Skip to content
This repository has been archived by the owner on Aug 8, 2019. It is now read-only.

Enchant DamageReductionPercent not shown on item #777

Open
Aviarium opened this issue Aug 30, 2017 · 5 comments
Open

Enchant DamageReductionPercent not shown on item #777

Aviarium opened this issue Aug 30, 2017 · 5 comments

Comments

@Aviarium
Copy link

I enchanted an item, but the enchant didnt make it to the item.

Event:
«Aviatros, the Irresponsible» met with Enchanter of Shrubs, the Guild Enchantress and wanted to get an item boost! Fortunately, «+25 leve-linear accursed worldly cambric unicorn horn of the spirit» was successfully enchanted to +26! [damageReductionPercent 0 -> 1]

Items Stats after enchant:
+28 leve-linear accursed worldly cambric unicorn horn of the spirit Found Aug 29, 2017, 5:50:27 AM; Score: 140,569 [Base: 133,778] (105%)
323 STR
1,671 CON
893 DEX
5,351 AGI
4,624 INT
1,407 LUK
silver(703) xp(703) sentimentality(500) salvage(1) dance(1) defense(1) crit(3) mp(2000)

I can't verify if the enchant is invisible, or not activated at all

@seiyria
Copy link
Member

seiyria commented Sep 28, 2017

IMO the solution here is to remove damageReductionPercent from ever being added to enchants, period.

@JukeDragh
Copy link
Contributor

JukeDragh commented Nov 17, 2017

If you want to prevent enchants of it, I think you would just delete/comment out :
https://github.com/IdleLands/IdleLands/blob/master/src/shared/stat-calculator.js#L10
All other instances of it just check if it is on the item.
I will drop a PR when you give me the word.

@seiyria
Copy link
Member

seiyria commented Nov 17, 2017

Doing that would mean it doesn't get added to the docs. A better solution would be to add a flag.

@JukeDragh
Copy link
Contributor

It isn't added to the docs to begin with. The only real part we need to worry about is enchantMax.

@seiyria
Copy link
Member

seiyria commented Nov 17, 2017

Oh, I see. That's why it has no desc, to avoid the docs. Well, yeah, enchantmax could be set to 0 then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants