Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isSessionSupported('immersive-vr') got false in molvic but true in FirefoxReality #196

Closed
lcgao opened this issue Jul 11, 2022 · 12 comments
Closed

Comments

@lcgao
Copy link

lcgao commented Jul 11, 2022

Hi, anyone has solution for this issue?

  1. Use the latest code and build with flavor noapiArm64Debug.
  2. Access website: https://immersive-web.github.io/webxr-samples/.
  3. Show ❌ - VR support not detected.
  4. But it works on Firefox Reality browser.

Thanks!

@svillar
Copy link
Member

svillar commented Jul 11, 2022

Noapi flavour precisely means that no XR api is used, and thus no XR session could be created.

@svillar svillar closed this as completed Jul 11, 2022
@lcgao
Copy link
Author

lcgao commented Jul 12, 2022

Thanks but Firefox Reality also build with noapi flavour and created VR session. So what should I do if I want to have the same effect as Firefox Reality in Wolvic? Thank you in advance.

@lcgao
Copy link
Author

lcgao commented Jul 13, 2022

Hi, I went through all the commits and found commit #70 and #145 make this situation.

I would like to know how to create a XR session with my own XR device in a new flavor, please advice.
Thanks a lot!

@svillar
Copy link
Member

svillar commented Jul 25, 2022

Hi, I went through all the commits and found commit #70 and #145 make this situation.

I would like to know how to create a XR session with my own XR device in a new flavor, please advice. Thanks a lot!

That's because in #70 we changed the protocol to talk to Gecko. See #210 (comment)

@lcgao
Copy link
Author

lcgao commented Jul 25, 2022

OK, so I just need to use the branch wolvic_release instead, right?

@svillar
Copy link
Member

svillar commented Jul 25, 2022

OK, so I just need to use the branch wolvic_release instead, right?

Correct. We're currently evaluating reverting #70 because in the end it didn't work as expected and seems to be causing major disruptions for potential new contributors.

@lcgao
Copy link
Author

lcgao commented Jul 25, 2022

OK, this is great! Actually I did the revert-operation in our own Wolvic for this issue.
Anyway it would be better if Wolvic official do a fix (integrate new Gecko or revert #70), expecting it.

Thanks.

@lcgao
Copy link
Author

lcgao commented Jul 25, 2022

Please also check commit 24902f1.
I think VRBrowser::InitializeJava() should be called before VRBrowser::RegisterExternalContext() because the latter is a function that calls Java method. Otherwise, ValidateStaticMethodID() may return false with error message "JNI::%s failed. Java not initialized."

@svillar
Copy link
Member

svillar commented Jul 25, 2022

Please also check commit 24902f1.
I think VRBrowser::InitializeJava() should be called before VRBrowser::RegisterExternalContext() because the latter is a function that calls Java method. Otherwise, ValidateStaticMethodID() may return false with error message "JNI::%s failed. Java not initialized."

yeah we know about that. However that InitializeJava is a bit missleading because it does not initialize java but just attach java resources to the new render thread. The JNI call required by RegisterExternalContext can be called anyway.

@lcgao
Copy link
Author

lcgao commented Jul 25, 2022

But actually this does cause isSessionSupported('immersive-vr') returning false.

@svillar
Copy link
Member

svillar commented Jul 25, 2022

But actually this does cause isSessionSupported('immersive-vr') returning false.

That should not be the cause. That call only returns false (using Gecko) whenever the XR library is not able to list the available devices.

@DavidChen528
Copy link

@lcgao ,Hi,Have you solved this problem yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants