Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates #598

Merged
merged 5 commits into from
May 30, 2024
Merged

CI updates #598

merged 5 commits into from
May 30, 2024

Conversation

alexdewar
Copy link
Collaborator

@alexdewar alexdewar commented May 30, 2024

Various small CI changes:

  • Remove duplicate entry from dependabot.yml
  • Don't run CI for push and pull requests
  • Enable caching of poetry packages

Closes #597.

Tagging @cc-a in case you're interested!

@alexdewar alexdewar requested review from dalonsoa and dc2917 May 30, 2024 09:10
@alexdewar alexdewar changed the title Ci updates CI updates May 30, 2024
@alexdewar alexdewar marked this pull request as ready for review May 30, 2024 09:11
Currently the poetry cache for the GitHub Actions appears not to be being used.

See: actions/setup-python#374
@alexdewar alexdewar marked this pull request as draft May 30, 2024 09:46
@alexdewar
Copy link
Collaborator Author

Hmm... currently the cache seems to not be being used, even though I rebased this branch to test it: poetry cache is not found

I've found a workaround: actions/setup-python#374

Maybe that'll do the trick...

@alexdewar
Copy link
Collaborator Author

That seemed to do it :-D

@alexdewar alexdewar marked this pull request as ready for review May 30, 2024 09:48
@alexdewar
Copy link
Collaborator Author

Though seemingly the cache isn't being used for the Windows runner... Oh well.

Comment on lines +33 to +37
- name: Install Poetry
uses: abatilo/[email protected]
with:
poetry-version: 1.8.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is setting up Poetry before python the right thing to do in order to use caching?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it seems to be.

@alexdewar alexdewar merged commit f40795d into main May 30, 2024
7 checks passed
@alexdewar alexdewar deleted the ci_updates branch May 30, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Cache packages to speed up testing
2 participants