Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for generate_full_structure #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug fix for generate_full_structure #306

wants to merge 1 commit into from

Conversation

kccwing
Copy link
Collaborator

@kccwing kccwing commented Nov 7, 2024

not caught since nobody was using this - but will become a dependency of the statictrimMB solver so am getting this done now. thanks!

ben-l-p
ben-l-p approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@ben-l-p ben-l-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for fixing Kelvin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-l-p ben-l-p ben-l-p approved these changes

@wong-hl wong-hl wong-hl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kccwing @wong-hl @ben-l-p