Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we still need upgrade from really old versions? #1618

Open
fiammybe opened this issue Feb 2, 2025 · 1 comment
Open

do we still need upgrade from really old versions? #1618

fiammybe opened this issue Feb 2, 2025 · 1 comment
Labels
cleanup Removal of unused code
Milestone

Comments

@fiammybe
Copy link
Member

fiammybe commented Feb 2, 2025

In the system module, we have files to support an upgrade from XOOPS even. Technically, there is no overlap in supported PHP versions with those old ImpressCMS versions. I propose we remove the upgrade options for everything that is older than 1.4.2 (first version to support PYP 7.4, which is our minimal version right now).

Reason : less code to maintain and less migration paths to test. If older versions need to upgrade first to 1.4.2 before going to 2.0.2, we have less differences in what comes in from a system module point of view.

@fiammybe fiammybe added the cleanup Removal of unused code label Feb 2, 2025
@fiammybe fiammybe added this to the 2.0.2 milestone Feb 2, 2025
@skenow
Copy link
Contributor

skenow commented Feb 6, 2025

We can definitely do without the /upgrade folder that handles XOOPS upgrades and then migration to ImpressCMS, and the ICMS1.0 to 1.1 upgrade. At this point, we're only going to be dealing with people upgrading from one version of ImpressCMS to another.

The next major hurdle is when we went from our original releases to the IPF conventions in 1.3. Upgrading from versions prior to that to ones since then are going to involve more than a one-step upgrade can handle.

Finally, the removal of /class, /kernel, and functions that had been replaced and deprecated affects the last stage of upgrading. I think 1.4.2 was the version where those began to be removed (there was enough notice and time to plan and prepare).

It is rather nostalgic to look back at those upgrade files and see where we've been and what we've done. Other than that, they don't serve much other purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Removal of unused code
Projects
None yet
Development

No branches or pull requests

2 participants