Add option to allow flags anywhere after last literal argument #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
force-pushed
the
any-location-flags
branch
2 times, most recently
from
c80d8b7 to
f6ca4c8
Compare
|
I've cleaned-up the code to a state where it's stable, i'd love to get some reviews or comments regarding it. |
jpenilla
requested changes
Nov 5, 2022
cloud-core/src/main/java/cloud/commandframework/CommandManager.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/arguments/compound/FlagArgument.java
Show resolved
Hide resolved
jpenilla
requested changes
Nov 6, 2022
cloud-core/src/main/java/cloud/commandframework/CommandManager.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/context/CommandContext.java
Outdated
Show resolved
Hide resolved
Pablete1234
requested review from
jpenilla
and removed request for
Citymonstret
Pablete1234
force-pushed
the
any-location-flags
branch
from
b67700b to
441f42e
Compare
Pablete1234
force-pushed
the
any-location-flags
branch
2 times, most recently
from
6305a79 to
4c07994
Compare
Signed-off-by: Pablete1234 <[email protected]>
Signed-off-by: Pablete1234 <[email protected]>
Pablete1234
force-pushed
the
any-location-flags
branch
from
4c07994 to
cdae122
Compare
jpenilla
approved these changes
Nov 20, 2022
Citymonstret
approved these changes
Nov 28, 2022
jpenilla
changed the title
jpenilla
pushed a commit
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept of how the library could support flags being located anywhere in the command, instead of just at the very end.
The code at this time is dirty just but the main point is to open up discussion about do's and don'ts since i'm new to the library, tests are passing (including the newly added ones) and the changes seem to be working as intended, although i'm sure there's missing corners).
Solves #230